At 1234559700 time_t, Gregor Best wrote: > > I've just realized that maybe the wording on my quick and dirty README > > may be misleading (since awesome actually already implements several > > freedesktop.org specs).
Yes, the name is totally mischosen. :-) > > I'm not sure what would be the better way to integrate it into awesome > > itself, or even if there would be interest on doing that. I'd appreciate > > any comments. Yes, that'd be interesting. > First I have to say: Damn nice work, I'm impressed :) However, I have two > things to say: you rely a lot on external programs, I haven't yet evaluated > whether the number of calls to os.execute() can be significantly lowered, but > I'll look into that. The second thing is, you use x-terminal-emulator for > console programs, which might be fine for Debian users, but I'd like to > specify > my own terminal to use. Nevertheless, good work, thanks a lot :) So far I agree. I've a couple of things to add. First, you need to split your module in two part: the first one that read and parse .desktop files. As it has been discussed yestarday on that list, or the user one I don't recall, there is common need to parse this files in the menu module you wrote, but also in the handling of a "backgroud desktop". Then, I think building the category from the parsed .desktop file would be better, if it's possible, since it would allow any arbitray section to be added without modifying your module. Finally, the icon handling for root categories is hardcoded, and I wonder how to do that better. I've no clue. Cheers, -- Julien Danjou // ᐰ <[email protected]> http://julien.danjou.info // 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD // Ferns will rule the world.
signature.asc
Description: Digital signature
