[
https://issues.apache.org/jira/browse/BOOKKEEPER-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396787#comment-13396787
]
Uma Maheswara Rao G commented on BOOKKEEPER-296:
------------------------------------------------
Hi Nijel,
Patch looks good. A few comments:
-
{noformat}
$KILL $TARGET_PID
+ sleep $BOOKKEEPER_STOP_TIMEOUT
+ if kill -0 $TARGET_PID > /dev/null 2>&1; then
+ echo "Bookkeeper Instance did not stop gracefully after
$BOOKKEEPER_STOP_TIMEOUT seconds: killing with kill -9"
+ $KILL -9 $TARGET_PID
+ fi
{noformat}
After kill, always it will wait for that timeout right? is it good to move it
to while and have intermediate timeouts with very less?
- There are some indentation issues. It will be good to maintain the
indentation correctly for more readability.
example:
{noformat}
+ if [ -f $BOOKKEEPER_PIDFILE ]; then
+ if kill -0 `cat $BOOKKEEPER_PIDFILE` > /dev/null 2>&1; then
+ echo Bookkeeper Instance already running as process `cat
$BOOKKEEPER_PIDFILE`.
+ exit 0
+ fi
+ fi
{noformat} there is one character diff in closing if.
- Bookkeeper Instance --> BookKeeper instance
- echo STOPPED the Bookkeeper instance. --->echo Stopped the BookKeeper instance
- killing with kill -9 --> forcibly(kill -9) stopping the BookKeeper instance?
- Failed to Write --> Failed to write
- nohup java $OPTS org.apache.bookkeeper.util.LocalBookKeeper $NUMBER
$BOOKIE_CONF $@ >> bookkeeper.out 2>&1 < /dev/null &
+
Looks this is directly starting process as background process. This may not
prompt the confimation options..etc for format commands tomorrow.
Shall we have deamon scripts separately like how Hadoop has today?
@Sijie, Ivan, Falvio, could you please add your comments?
> It's better provide stop script for bookie
> ------------------------------------------
>
> Key: BOOKKEEPER-296
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-296
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Affects Versions: 4.0.0
> Reporter: Brahma Reddy Battula
> Attachments: BOOKKEEPER-296.1.patch, BOOKKEEPER-296.patch
>
>
> Currently there is no command to stop bookie in 4.0.0..It's better to provide
> stop command for bookie.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
