[
https://issues.apache.org/jira/browse/BOOKKEEPER-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401975#comment-13401975
]
Sijie Guo commented on BOOKKEEPER-296:
--------------------------------------
the patch is pretty good, Surendra.
one question about the dailyrolling appender. this appender doesn't have
maxFileSize property as below. it would be better to remove this property to
match the appender.
{quote}
log4j:WARN No such property [maxFileSize] in
org.apache.log4j.DailyRollingFileAppender.
{quote}
btw, it is better to put BOOKIE_STOP_TIMEOUT & BOOKIE_PID_DIR in bkenv.sh as
default and comment out them.
> It's better provide stop script for bookie
> ------------------------------------------
>
> Key: BOOKKEEPER-296
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-296
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Affects Versions: 4.0.0
> Reporter: Brahma Reddy Battula
> Attachments: BOOKKEEPER-296.1.patch, BOOKKEEPER-296.2.patch,
> BOOKKEEPER-296.3.patch, BOOKKEEPER-296.patch
>
>
> Currently there is no command to stop bookie in 4.0.0..It's better to provide
> stop command for bookie.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
