[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396866#comment-13396866
 ] 

Sijie Guo commented on BOOKKEEPER-296:
--------------------------------------

thanks nijel's patch.

comments based on Uma's previous comment.

1. I prefer using "Bookie Server" than "Bookkeeper Instance" to make things 
clearer.

2. 'kill -9' is a bad idea to shutdown a bookie server. We had a shutdown hook 
to flush data to ensure data durability. 'kill -9' would skip shutdown hook, 
which would make data corrupted. If you had huge number of ledgers owned in a 
bookie, it might take a long time to shutdown a bookie. I suggested to print a 
WARN message to let admin guys know 'the bookie server doesn't shutdown in a 
timeout period', so admin guys could look into log files to know what happened.

3. is it able to make bookkeeper.out to store in a configurable path (in 
environment variable), like logs directory? 

4. It would be better to let user decide whether to start the process in 
background or foreground. (Uma's proposal having deamon scripts as Hadoop might 
be a good choice). running bookie server in foreground would be easy and useful 
for development.
                
> It's better provide stop script for bookie
> ------------------------------------------
>
>                 Key: BOOKKEEPER-296
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-296
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-server
>    Affects Versions: 4.0.0
>            Reporter: Brahma Reddy Battula
>         Attachments: BOOKKEEPER-296.1.patch, BOOKKEEPER-296.patch
>
>
> Currently there is no command to stop bookie in 4.0.0..It's better to provide 
> stop command for bookie.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to