[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397282#comment-13397282
 ] 

Uma Maheswara Rao G commented on BOOKKEEPER-296:
------------------------------------------------

#1 Agreed.

#2. Right. But after the experience's, I think we have this kind of pattern in 
Hadoop and Zookeeper also.

Hadoop script:

{noformat}
 if [ -f $pid ]; then
      TARGET_PID=`cat $pid`
      if kill -0 $TARGET_PID > /dev/null 2>&1; then
        echo stopping $command
        kill $TARGET_PID
        sleep $HADOOP_STOP_TIMEOUT
        if kill -0 $TARGET_PID > /dev/null 2>&1; then
          echo "$command did not stop gracefully after $HADOOP_STOP_TIMEOUT 
seconds: killing with kill -9"
          kill -9 $TARGET_PID
        fi
      else
{noformat}

ZK script:

{noformat}
echo -n "Stopping zookeeper ... "
    if [ ! -f "$ZOOPIDFILE" ]
    then
      echo "no zookeeper to stop (could not find file $ZOOPIDFILE)"
    else
      $KILL -9 $(cat "$ZOOPIDFILE")
      rm "$ZOOPIDFILE"
      echo STOPPED
    fi
    exit 0
{noformat}

Even though we have many ledgers, that information will be flushed periodically 
by SyncThread in Bookie right. I am not sure, there is a chance of accumulating 
huge data to flush here even after some timeout wait. That situation is always 
risk, because of sudden poweroff or rack shutdown. can increase this time to 
some reasonable period?
 
                
> It's better provide stop script for bookie
> ------------------------------------------
>
>                 Key: BOOKKEEPER-296
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-296
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-server
>    Affects Versions: 4.0.0
>            Reporter: Brahma Reddy Battula
>         Attachments: BOOKKEEPER-296.1.patch, BOOKKEEPER-296.patch
>
>
> Currently there is no command to stop bookie in 4.0.0..It's better to provide 
> stop command for bookie.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to