[
https://issues.apache.org/jira/browse/BOOKKEEPER-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397686#comment-13397686
]
Uma Maheswara Rao G commented on BOOKKEEPER-296:
------------------------------------------------
Thanks a lot for the update on patch!
Few small comments:
-
+#/**
+# * Copyright 2007 The Apache Software Foundation
+# *
Apache header has 2007. we can remove that line.
-
+usage="Usage: bookkeeper-daemon.sh (start|stop) <command> <args...>"
Usage can have about -force option explicitely?
-
do
+ echo "Shutdown is in progress... Please wait..."
+ sleep 1
+ count=`expr $count + 1`
will this echo statement prints 30 times, if you have 30 sec wait time? can we
print once and give the wait time?
-
BookKeeper is not stopped completely. -> decided as Bookie Server right?
-
+ fileName=$location/$command.out
+ $JAVA_HOME/bin/jstack $TARGET_PID > $fileName
+ echo Thread dumps are taken for analysis at $fileName
I like this. It is a good idea to take thread dumps on force kill.
-
{noformat}
-log4j.appender.ROLLINGFILE=org.apache.log4j.DailyRollingFileAppender
+log4j.appender.ROLLINGFILE=org.apache.log4j.RollingFileAppender
{noformat}
changing the default log format can go into different JIRA, as that is not
related to this JIRA?
> It's better provide stop script for bookie
> ------------------------------------------
>
> Key: BOOKKEEPER-296
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-296
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
> Affects Versions: 4.0.0
> Reporter: Brahma Reddy Battula
> Attachments: BOOKKEEPER-296.1.patch, BOOKKEEPER-296.2.patch,
> BOOKKEEPER-296.patch
>
>
> Currently there is no command to stop bookie in 4.0.0..It's better to provide
> stop command for bookie.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
