[
https://issues.apache.org/jira/browse/BOOKKEEPER-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414897#comment-13414897
]
Sijie Guo commented on BOOKKEEPER-310:
--------------------------------------
the patch is quite good except test cases.
A better test case is to check whether the MessageSeqId returned by published
requests equals to the MessageSeqId received by a subscriber. Just asserting
whether it is null doesn't make sense.
Especially for async publish, you'd better concurrently async publish several
messages and check their message seq id are right and same as the message seq
id received by subscriber. to make sure publish request doesn't return wrong
message seq id.
> Changes in hedwig server to support JMS spec
> --------------------------------------------
>
> Key: BOOKKEEPER-310
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-310
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Mridul Muralidharan
> Attachments: hedwig-server.patch, hedwig-server.patch.1,
> hedwig-server.patch.3, hedwig-server.patch.4
>
>
> The primary changes are :
> a) Support modified protocol changes (optional body).
> b) Return the published message's seq-id in the response.
> c) Minor bugfix to Array indexing in bucket which was triggered in a testcase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
