[
https://issues.apache.org/jira/browse/BOOKKEEPER-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409327#comment-13409327
]
Mridul Muralidharan commented on BOOKKEEPER-310:
------------------------------------------------
bq. 1) protocol changes in BOOKKEEPER-309:
It was my oversight that I did not realize it was a publically exposed api
between modules ! Should have looked at the diff's more carefully, my apolgoes.
Actually there is no reason for it to exist in protocol and can be easily moved
as a private method within PublishHandler.
Will that be fine ?
bq. seems body is a required field for Message. is there anything special you
considered?
I had made body optional in an earlier change, but reverted following Ivan's
comment.
The commented out code slipped my cleanup.
bq. I forgot to say that it would be better to have test cases to test
returning message seq id for publish requests.
I dont have specific testcases, but then quite a lot of activemq testcases in
JMS provider module will fail if seq-id is not returned :-)
Some of them even try to correlate between publisher and consumer : though I
think in a clustered deployment, this will fail - so we might need to relook at
these testcases in future anyway ...
I will try to find a publish/subscribe() testcase in server and add an assert
to check for the published seq-id.
> Changes in hedwig server to support JMS spec
> --------------------------------------------
>
> Key: BOOKKEEPER-310
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-310
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Mridul Muralidharan
> Attachments: hedwig-server.patch, hedwig-server.patch.1
>
>
> The primary changes are :
> a) Support modified protocol changes (optional body).
> b) Return the published message's seq-id in the response.
> c) Minor bugfix to Array indexing in bucket which was triggered in a testcase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
