[
https://issues.apache.org/jira/browse/BOOKKEEPER-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409331#comment-13409331
]
Sijie Guo commented on BOOKKEEPER-310:
--------------------------------------
{quote}
Actually there is no reason for it to exist in protocol and can be easily moved
as a private method within PublishHandler.
Will that be fine ?
{quote}
it is OK to put publishResponse in PublishHandler.
{quote}
I dont have specific testcases, but then quite a lot of activemq testcases in
JMS provider module will fail if seq-id is not returned
I will try to find a publish/subscribe() testcase in server and add an assert
to check for the published seq-id.
{quote}
when you added a feature, it would better to add test cases for the feature
added itself. so the testcases could be in existed test suites to check return
seq-id.
> Changes in hedwig server to support JMS spec
> --------------------------------------------
>
> Key: BOOKKEEPER-310
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-310
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Mridul Muralidharan
> Attachments: hedwig-server.patch, hedwig-server.patch.1
>
>
> The primary changes are :
> a) Support modified protocol changes (optional body).
> b) Return the published message's seq-id in the response.
> c) Minor bugfix to Array indexing in bucket which was triggered in a testcase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
