[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438689#comment-13438689
]
Ivan Kelly commented on BOOKKEEPER-272:
---------------------------------------
I've had another look over this patch. I have some comments.
Logic change in ZkLedgerUnderreplicationManager is wrong [previous was wrong
also]. the break should be a return.
Auditor will be a top level daemon, so it should own its create it's own
LedgerManagers and ZooKeeper client. The only thing passed in to is should be
the configuration.
There should be a main method in AutoRecoveryManager. I think
AutoRecoveryManager should be responsible for running recoveryworker as well.
Im not sure whether the node which runs auditor should run a recovery worker at
the same time. This is an open question.
auditorElector should never be null, unless initialization fails. If
initialization fails, start and stop should never be run. Perhaps we should us
guava service [1] here as I also suggested to Uma for BOOKKEEPER-248.
Pattern "ELECTION_PATH + PATH_SEPARATOR + vote" is used in a lot of places. It
would be nice to move this into a method "String getVotePath(String vote);"
In Auditor, don't call getChildren from process(). Instead all it just after
the take() in main loop. In general, you shouldn't call any blocking methods
from the zk event handler thread.
> Provide automatic mechanism to know bookie failures
> ---------------------------------------------------
>
> Key: BOOKKEEPER-272
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-272
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-272.1.patch, BOOKKEEPER-272.2.patch,
> BOOKKEEPER-272.3.patch, BOOKKEEPER-272.Auditor.1.patch,
> BOOKKEEPER-272.Auditor.patch
>
>
> The idea is to build automatic mechanism to find out the bookie failures.
> Setup the bookie failure notifications to start the re-replication process.
> There are multiple approaches to findout bookie failures. Please refer the
> documents attached in BookKeeper-237.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
