[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14142902#comment-14142902
]
Sijie Guo commented on BOOKKEEPER-773:
--------------------------------------
minor comment:
1.
{code}
+ LOG.info("Updating cookie file present in journalDirectory
{}", journalDirectory);
+ LOG.info("Updating cookie file present in ledgerDirectories
{}", ledgerDirectories);
+ newCookie.writeToDirectory(journalDirectory);
+ for (File dir : ledgerDirectories) {
+ newCookie.writeToDirectory(dir);
+ }
{code}
log on ledgerDirectories should after writeToDirectory before writing to ledger
directories.
2. I don't understand why you need a copy method. isn't the builder good
enough? I don't like adding such method in an immutable object.
otherwise, the patch looks good to me.
> Provide admin tool to rename bookie identifier in Cookies
> ---------------------------------------------------------
>
> Key: BOOKKEEPER-773
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.3.0
>
> Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 004-BOOKKEEPER-773-rename-bookieid.patch,
> 005-BOOKKEEPER-773-rename-bookieid.patch,
> 006-BOOKKEEPER-773-rename-bookieid.patch,
> 007-BOOKKEEPER-773-rename-bookieid.patch,
> 008-BOOKKEEPER-773-rename-bookieid.patch,
> 009-BOOKKEEPER-773-rename-bookieid.patch,
> 010-BOOKKEEPER-773-rename-bookieid.patch
>
>
> The idea of this JIRA to implement a mechanism to efficiently rename the
> bookie identifier present in the Cookies. Cookie information will be present
> in:
> - ledger & journal directories in each Bookie server
> - cookies znode in ZooKeeper
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
