[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14142936#comment-14142936
]
Sijie Guo commented on BOOKKEEPER-773:
--------------------------------------
ok. first of all, I don't know what is the difference between cookie.copy and
newBuilder(cookie).
{code}
/**
+ * Gets a copy of this cookie object.
+ *
+ * @return cookie builder object
+ */
+ Builder copy() {
+ Builder builder = newBuilder(this);
+ builder.setZnodeVersion(znodeVersion);
+ return builder;
+ }
{code}
secondly, I thought I had a comment in cookie builder to say we shouldn't have
znode version in builder. znode version should only exist in cookie instance,
which shouldn't be passed around between builders. I missed checking your patch
on addressing this comment.
https://issues.apache.org/jira/browse/BOOKKEEPER-782?focusedCommentId=14131090&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14131090
> Provide admin tool to rename bookie identifier in Cookies
> ---------------------------------------------------------
>
> Key: BOOKKEEPER-773
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.3.0
>
> Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 004-BOOKKEEPER-773-rename-bookieid.patch,
> 005-BOOKKEEPER-773-rename-bookieid.patch,
> 006-BOOKKEEPER-773-rename-bookieid.patch,
> 007-BOOKKEEPER-773-rename-bookieid.patch,
> 008-BOOKKEEPER-773-rename-bookieid.patch,
> 009-BOOKKEEPER-773-rename-bookieid.patch,
> 010-BOOKKEEPER-773-rename-bookieid.patch
>
>
> The idea of this JIRA to implement a mechanism to efficiently rename the
> bookie identifier present in the Cookies. Cookie information will be present
> in:
> - ledger & journal directories in each Bookie server
> - cookies znode in ZooKeeper
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
