[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14141751#comment-14141751
]
Sijie Guo commented on BOOKKEEPER-773:
--------------------------------------
addition to Ivan's comment
{code}
+ @Test(timeout = 60000)
+ public void testCookieDoesntExists() throws Exception {
+ for (int i = 0; i < bsConfs.size(); i++) {
+ ServerConfiguration conf = bsConfs.get(i);
+ BookieServer bks = bs.get(i);
+ bks.shutdown();
+
+ LOG.info("Perform renamebookieincookies command with true");
+ BookieShell bkShell = new BookieShell();
+ bkShell.setConf(conf);
+ // passing invalid, so will take the default as false
+ String[] argv = new String[] { "bkrename", "-cookie",
"useHostNameAsBookieID", "invalid" };
+ Assert.assertEquals("Failed to return the error code!", -1,
bkShell.run(argv));
+ }
+ }
{code}
why this test case need to run multiple times?
otherwise, the patch looks better.
[~rakeshr], could you provide a new patch addressed the comments?
> Provide admin tool to rename bookie identifier in Cookies
> ---------------------------------------------------------
>
> Key: BOOKKEEPER-773
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.3.0
>
> Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 004-BOOKKEEPER-773-rename-bookieid.patch,
> 005-BOOKKEEPER-773-rename-bookieid.patch,
> 006-BOOKKEEPER-773-rename-bookieid.patch,
> 007-BOOKKEEPER-773-rename-bookieid.patch,
> 008-BOOKKEEPER-773-rename-bookieid.patch
>
>
> The idea of this JIRA to implement a mechanism to efficiently rename the
> bookie identifier present in the Cookies. Cookie information will be present
> in:
> - ledger & journal directories in each Bookie server
> - cookies znode in ZooKeeper
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
