On Sun, 1 Oct 2023 05:13:25 GMT, Kim Barrett <[email protected]> wrote:
>> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix typo > > make/autoconf/flags-cflags.m4 line 923: > >> 921: AC_DEFUN([FLAGS_SETUP_GCC6_COMPILER_FLAGS], >> 922: [ >> 923: # This flags is required for GCC 6 builds as undefined behavior in >> OpenJDK code > > s/flags/flag/ Oops, missed it. Thanks for pointing it out! > make/hotspot/lib/CompileJvm.gmk line 165: > >> 163: DISABLED_WARNINGS_gcc := $(DISABLED_WARNINGS_gcc), \ >> 164: DISABLED_WARNINGS_gcc_ad_$(HOTSPOT_TARGET_CPU_ARCH).cpp := nonnull, >> \ >> 165: DISABLED_WARNINGS_gcc_ad_$(HOTSPOT_TARGET_CPU_ARCH)_pipeline.cpp := >> nonnull-compare, \ > > How about just waiting for the fix for JDK-8316907 to go in before doing this > one, rather than adding these > temporary warning disables. Yeah, that's what I wanted to do initially. But then the review on JDK-8316907 failed to make progress, so I figured I'd race this PR with that one. I will remove the warning suppressions before merging the second PR, whichever that is. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15982#discussion_r1342351752 PR Review Comment: https://git.openjdk.org/jdk/pull/15982#discussion_r1342351782
