On Mon, 2 Oct 2023 07:24:06 GMT, Daniel Jeliński <[email protected]> wrote:
>> make/hotspot/lib/CompileJvm.gmk line 165: >> >>> 163: DISABLED_WARNINGS_gcc := $(DISABLED_WARNINGS_gcc), \ >>> 164: DISABLED_WARNINGS_gcc_ad_$(HOTSPOT_TARGET_CPU_ARCH).cpp := >>> nonnull, \ >>> 165: DISABLED_WARNINGS_gcc_ad_$(HOTSPOT_TARGET_CPU_ARCH)_pipeline.cpp >>> := nonnull-compare, \ >> >> How about just waiting for the fix for JDK-8316907 to go in before doing >> this one, rather than adding these >> temporary warning disables. > > Yeah, that's what I wanted to do initially. But then the review on > JDK-8316907 failed to make progress, so I figured I'd race this PR with that > one. > I will remove the warning suppressions before merging the second PR, > whichever that is. Fix for JDK-8316907 is merged now. Suppressions removed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15982#discussion_r1342546648
