On Mon, 2 Oct 2023 14:01:10 GMT, Julian Waters <[email protected]> wrote:
>> I reverted the quotes. >> Didn't get your question; are you suggesting to rename the variable? I'd >> rather not do that, because 1) it increases the patch size, 2) all variables >> are global, so renaming might have unintended consequences, and 3) the old >> name is good enough. > > Ah no, I meant the comment, from This flag -> These flag(s), since it's > implied that this site is where multiple gcc specific flags should be placed > in the future. Just a small nit, nothing serious Ah. This place is for GCC6-related flags only, other flags are added in other places. I'm pretty sure we won't add any more flags for GCC6. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15982#discussion_r1343531371
