On Mon, 2 Oct 2023 08:26:34 GMT, Daniel Jeliński <[email protected]> wrote:
>> Please review this patch that reenables `delete-null-pointer-checks`
>> optimization in GCC and Clang.
>>
>> It also disables `nonnull-compare` warning that is now triggered in debug
>> builds. The problematic code will be addressed by #15927.
>>
>> Mach5 Tier1-5 testing clean.
>
> Daniel Jeliński has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fix typo
make/autoconf/flags-cflags.m4 line 928:
> 926: FLAGS_COMPILER_CHECK_ARGUMENTS(ARGUMENT: [$NO_LIFETIME_DSE_CFLAG],
> 927: PREFIX: $2, IF_FALSE: [NO_LIFETIME_DSE_CFLAG=""])
> 928: $1_GCC6_CFLAGS=${NO_LIFETIME_DSE_CFLAG}
Might be safer to leave the quote around the DSE flag. Also, why not flag(s)
instead?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15982#discussion_r1342419189
