On Mon, 2 Oct 2023 08:38:45 GMT, Julian Waters <[email protected]> wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix typo
>
> make/autoconf/flags-cflags.m4 line 928:
>
>> 926: FLAGS_COMPILER_CHECK_ARGUMENTS(ARGUMENT: [$NO_LIFETIME_DSE_CFLAG],
>> 927: PREFIX: $2, IF_FALSE: [NO_LIFETIME_DSE_CFLAG=""])
>> 928: $1_GCC6_CFLAGS=${NO_LIFETIME_DSE_CFLAG}
>
> Might be safer to leave the quote around the DSE flag. Also, why not flag(s)
> instead?
I reverted the quotes.
Didn't get your question; are you suggesting to rename the variable? I'd rather
not do that, because 1) it increases the patch size, 2) all variables are
global, so renaming might have unintended consequences, and 3) the old name is
good enough.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15982#discussion_r1342555104
