On Mon, 25 Mar 2024 11:27:17 GMT, Robbin Ehn <r...@openjdk.org> wrote:

> src/java.base/share/native/libzip/zlib/zconf.h:# define ZEXPORT 
> __declspec(dllexport)

zlib is third party source that is copied into our repo. I did not mean that 
what I said for that applies to it. (Also, we should not really export *any* 
functions from zlib -- we encapsulate it in our own native shared library. I 
might have to look into if we are doing this wrong on Windows. But that is a 
separate question from this PR.)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18400#issuecomment-2017814752

Reply via email to