On Thu, 21 Mar 2024 06:58:43 GMT, Robbin Ehn <r...@openjdk.org> wrote:
>> Hi, please consider. >> >> [8327045](https://bugs.openjdk.org/browse/JDK-8327045) hide these symbols. >> Tested with gcc and clang, and llvm and binutils backend. >> >> I didn't find any use of the "DLL_ENTRY", so I removed it. >> >> Thanks, Robbin > > Robbin Ehn has updated the pull request incrementally with one additional > commit since the last revision: > > remove swap file It is original code in the JDK library. zlib is copied in from elsewhere. That is what I mean by third party code. The only reason hsdis is specially treated is due to the fact that the original implementation was based on binutils, which could not -- for legal reason -- be distributed as a compiled library alongside the JDK. That forced us to erect an artificial barrier. There are multiple JBS issues trying to rectify this, with different approaches, to get a non-binutils hsdis library build and shipped as any other native library in the JDK. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18400#issuecomment-2017939559
