On Thu, 21 Mar 2024 06:58:43 GMT, Robbin Ehn <r...@openjdk.org> wrote:
>> Hi, please consider. >> >> [8327045](https://bugs.openjdk.org/browse/JDK-8327045) hide these symbols. >> Tested with gcc and clang, and llvm and binutils backend. >> >> I didn't find any use of the "DLL_ENTRY", so I removed it. >> >> Thanks, Robbin > > Robbin Ehn has updated the pull request incrementally with one additional > commit since the last revision: > > remove swap file > > src/java.base/share/native/libzip/zlib/zconf.h:# define ZEXPORT > > __declspec(dllexport) > > zlib is third party source that is copied into our repo. I did not mean that > what I said for that applies to it. (Also, we should not really export _any_ > functions from zlib -- we encapsulate it in our own native shared library. I > might have to look into if we are doing this wrong on Windows. But that is a > separate question from this PR.) Okay, so the difference is that me and @theRealAph consider hsdis a thrid party library, although the JDK folks maintain it. (correct me if I'm wrong) ------------- PR Comment: https://git.openjdk.org/jdk/pull/18400#issuecomment-2017828723
