On Wed, 2008-09-24 at 15:53 +0000, Vladimir Dronnikov wrote: > > Most serious issue was the fact that current bb sendmail uses the from > > address in the EHLO/HELO message. The rfc1869 (section 4.2) says it > > should be a domain not an address. So my MTA correctly dicarded the > > invalid EHLO. > Hmmm. RFC 2821 at 4.1.1.1 says a client should provide > _fully-qualified_ domain name.
Correct. > And what if yours is simply localhost? Thats why I use the domain part of the senders email address. > In that case the client should send reverse address verbatim. technically yes. But typical busybox usage is not multiuser *nix servers. > So your MTA INcorrectly discards that EHLO. no. I think it was my postfix's reject_invalid_hostname option that rejected the email address in the EHLO. > > I solved this by using the domain part in the from address. This requires > > that the from address has an '@' which i think is > > ok in todays world (10 years ago it would be different) > Great. But avoid dying when no '@' occured. Just complain of that > would be enough IMHO. We should probably not even complain. Need to support MAIL FROM: <> as others said. > And, please, enclose the very first read of > opt_from (domain=strchr...) in sane() to avoid issues. ok > > Third, the enviroment variable HOSTNAME is a "reserverd" variable for > > bash so I changed it to SMTPHOST. > Personally, I would get completely rid of environ here. -H switch is > good, The problem is that: ssmtp configures the "mailhub", in ssmtp.conf, postfix configures the relayhost in main.cf and with old sendmail you define SMART_HOST in your .m4 file. All of those have this in common: None have an command line option to specify which server the mail should be sent via. They all configure that other place. This means that if you want to be able to use either ssmtp/postfix/sendmail or busybox sendmail you cannot use the -H option. You could ofcourse check if the sendmail in $PATH is pointing to busybox and if it is you add the -H option, but thats just pain. So using a env var was an cheap way to get away from having a config file. > and localhost is the sane fallback IMO. If you use busybox sendmail, then I'm pretty sure you dont have a real MTA listening on localhost port 25. (because if you do have postfix running then you use the postfix sendmail and not busybox sendmail) But if you want to fallback to something then localhost is probably what we want. > > Sendmail is a good addition to busybox. Thanks! > Thank you! Let us tune it! > > -- > Vladimir _______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox
