Joseph J VLcek wrote: > Ethan Quach wrote: >> Hello again caimaniacs, >> >> Thanks for those that provided comments for the early code review. >> Posted here is the incremental webrev of the changes for code review >> comments plus other fixes that we've pushed since. >> >> http://cr.opensolaris.org/~equach/webrev.SnapUpgrade.2 >> >> >> Additionally as a reference, below is the webrev of the overall snap >> upgrade gate synced up against the current slim_source base. >> >> http://cr.opensolaris.org/~equach/webrev.SnapUpgrade >> >> >> Again comments welcomed, particularly from those who provided the >> initial comments on the early review. >> >> >> Thanks, >> -Ethan >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > Last Friday I had sent you 2 different emails. One @ 4pm ET (covering > mostly be_create.c) and another @ 9:30pm ET (covering be_utils.c, > be_rename.c & be_rename.c). My review comments from the first email have > been reflected in the code. > > My incremental review for the comments in that have been addressed are: > > +-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-= > be_create.c > +-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-= > > Line 389 should be changed: > > From: > 389 int ret; > > To: > > 389 int ret = 0;
Fixed > > > line 548 should be changed: > > From: > return (0); > To: > return (ret); Fixed > > > Once my comments covering be_utils.c, be_rename.c & be_rename.c are > reflected in the code let me know and I will do the incremental review > for that. I'm pushing them with the changes for this. > > Joe > Thanks for the review!!! -evan
