Dave Miner wrote: > Ethan Quach wrote: >> Hello again caimaniacs, >> >> Thanks for those that provided comments for the early code review. >> Posted here is the incremental webrev of the changes for code review >> comments plus other fixes that we've pushed since. >> >> http://cr.opensolaris.org/~equach/webrev.SnapUpgrade.2 >> >> >> Additionally as a reference, below is the webrev of the overall snap >> upgrade gate synced up against the current slim_source base. >> >> http://cr.opensolaris.org/~equach/webrev.SnapUpgrade >> >> >> Again comments welcomed, particularly from those who provided the >> initial comments on the early review. >> > > usr/src/cmd/Makefile: > > 60: can just combine this with 57, i.e. > > $(SUBDIRS) $(PYTHONSUBDIRS): FRC
done. > > usr/src/cmd/beadm/Makefile: > > 53-54: Seems like we could add a suffix rule for .py to Makefile.master > as a cleaner and more general answer; that should allow for using the > standard PROG and its derived definitions rather than the I think ideally we should compile the .py file as well (and perhaps deliver the .pyc with our package? I don't know that much about python so I'm not really sure if we should or not.) I'll look at adding the rule with the Makefile.master, that part doesn't look too hard. > > be_utils.c > > 567-569: the fd's here should be fp's and the fp an fd fixed. > > 1320: "simply" fixed. > > 1330: Some example or definition of what a valid name looks like would > be good to include here Added some examples. > > SUNWinstall-libs/depend: > > should depend on SUNWzfs Added dependencies for SUNWzfsr and SUNWzfsu > > SUNWinstall-libs/prototype_i386, prototype_sparc > > 34: lines joined here Fixed. Looks like the other packages in the gate suffer from this too. I'll leave them be unless you really care. thanks, -ethan > > Dave > > > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
