Ethan Quach wrote: > Hello again caimaniacs, > > Thanks for those that provided comments for the early code review. > Posted here is the incremental webrev of the changes for code review > comments plus other fixes that we've pushed since. > > http://cr.opensolaris.org/~equach/webrev.SnapUpgrade.2 > > > Additionally as a reference, below is the webrev of the overall snap > upgrade gate synced up against the current slim_source base. > > http://cr.opensolaris.org/~equach/webrev.SnapUpgrade > > > Again comments welcomed, particularly from those who provided the > initial comments on the early review. >
usr/src/cmd/Makefile: 60: can just combine this with 57, i.e. $(SUBDIRS) $(PYTHONSUBDIRS): FRC usr/src/cmd/beadm/Makefile: 53-54: Seems like we could add a suffix rule for .py to Makefile.master as a cleaner and more general answer; that should allow for using the standard PROG and its derived definitions rather than the be_utils.c 567-569: the fd's here should be fp's and the fp an fd 1320: "simply" 1330: Some example or definition of what a valid name looks like would be good to include here SUNWinstall-libs/depend: should depend on SUNWzfs SUNWinstall-libs/prototype_i386, prototype_sparc 34: lines joined here Dave
