> usr/src/cmd/text-install/osol_install/text_install/text_install.py

- line 149: why is the loglevel hard coded to 0, instead of the
value in options.log_level?

I can't recall why I did that. It was either:
(a) A conflict with other logging services that will get resolved when the text installer is fully CUD'ified to use just one approach to logging, or
(b) a typo / left-over from testing.


Hi Karen,

I wanted to follow up on this point:

There is currently a bug in the InstallLogger, CR 7004649. I believe I've got that bug addressed with this iteration of the SCI tool:
http://cr.opensolaris.org/~kemitche/sci.1/usr/src/lib/install_logging_pymod/logger.py.sdiff.html

(Side note to Jan: take note that I've fixed that bug for when the push of SCI v1 goes through)

The reason I had this hard-coded to 0 was due to the fact that options.log_level is initially set to a string, and I'd not corrected that in text_install.py (it's properly handled in sysconfig.py, since that tool is fully CUD - but the text installer is straddling the logging fence, as it were, and the setup_logging code will need to be revamped during the CUD transition of that installer). So, I thought I was running into an aspect of the above CR that resulted from using logging.basicConfig(), but in reality, I simply wasn't properly setting the log_levels (and the logging services were quietly ignoring that I'd given them a string instead of an int for the loglevel).

- Keith
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to