Hi John,
A couple comments ...
server.xml
--------------
77,83 - is 10 seconds really enough for these? Would it cause any harm
to up these to 30?
setup-image.sh
--------------------
431,439 - Can you qualify these grep's better so that we don't have to
worry about name intersection if/when we need to introduce more stuff
into the version file in the future. i.e. use "^IMAGE_VERSION=" instead.
thanks,
-ethan
On 01/21/11 11:59, John Fischer wrote:
All,
Here is hopefully the final webrev review for this project.
http://cr.opensolaris.org/~johnfisc/webserver/webserver-design-5/
http://cr.opensolaris.org/~johnfisc/webserver/webserver-design-diff-5/
The changes include everything that has been discussed.
Plus issues that have been found by Mary (Trouble Maker) Ding,
myself during tests and the issue that Sanjay found yesterday.
Thanks,
John
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
