Dave and Ethan,
Here is an updated webrev based upon your comments.
http://cr.opensolaris.org/~johnfisc/webserver/webrev-webserver-design-final/
http://cr.opensolaris.org/~johnfisc/webserver/webrev-webserver-design-diff-final/
In the diff-final you will notice that there are additional changes listed.
These are the differences in the code from the last review. However,
these changes are only from an hg merge command. I have double
checked the changes from a clean slim_source clone and they are correct.
These changes are not present within the design-final webrev.
Mary has given a go. Ethan and I have researched and cleared the bugs
filed by QE. So this is the last hurdle.
Thanks,
John
On 01/26/11 04:55 PM, John Fischer wrote:
Ethan,
Thanks for the review.
John
On 01/26/11 03:12 PM, Ethan Quach wrote:
server.xml
--------------
77,83 - is 10 seconds really enough for these? Would it cause any
harm to up these to 30?
That should be fine.
setup-image.sh
--------------------
431,439 - Can you qualify these grep's better so that we don't have
to worry about name intersection if/when we need to introduce more
stuff into the version file in the future. i.e. use
"^IMAGE_VERSION=" instead.
Will do.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
