Ethan,
Thanks for the review.
John
On 01/26/11 03:12 PM, Ethan Quach wrote:
server.xml
--------------
77,83 - is 10 seconds really enough for these? Would it cause any
harm to up these to 30?
That should be fine.
setup-image.sh
--------------------
431,439 - Can you qualify these grep's better so that we don't have to
worry about name intersection if/when we need to introduce more stuff
into the version file in the future. i.e. use "^IMAGE_VERSION="
instead.
Will do.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
