Nirmal,
Before If there was a zone and we were doing IPS OR if we weren't in a
zone or we weren't doing IPS
then we would still get stdout from the checkpoint. Old code:
1094 if self.options.zonename and sw.tran_type.upper() ==
"IPS":
1095 # If we're installing a zone and transfer type is
1096 # IPS, append a kwarg specifying the zone's
zonename
1097 # to the transfer checkpoint. Also append a kwarg
1098 # specifying that we're allowing the checkpoint to
1099 # show progress to stdout.
1100 arg_dict = {"zonename": self.options.zonename,
1101 "show_stdout": True}
1102 self.engine.register_checkpoint(*ckpt_info,
1103 kwargs={"arg": arg_dict})
1104 else:
1105 arg_dict = {"show_stdout": True}
1106 self.engine.register_checkpoint(*ckpt_info,
1107 kwargs={"arg": arg_dict})
If I am reading the new code correctly if we aren't doing IPS then we
won't get stdout from
the checkpoint. Is this expected and desired new behavior?
Thanks,
John
On 08/22/12 07:35 AM, Nirmal Agarwal wrote:
Hi all,
Can I please get 2 code reviews for CR 7192373.
7192373 AI installation fails when SVR4 packages are specified in
manifest
Webrev:
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7192373/webrev/
Pep8 is clean.
Pylint output is unchanged.
Unit tests : Pass
Testing :
--> AI installation on physical system with SVR4 packages specified in
manifest
--> Non Global Zone installation on an installed system using manifest
with SVR4 packages specified.
Regards,
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
