Hi Ethan,
Thanks for the review.
On 8/23/2012 12:37 AM, Ethan Quach wrote:
Nirmal,
The code changes look ok, though I have a question.
Are there any consequences of running 'pkgadm sync ... ' if a pkgadd
hadn't happened? I ask because there seem to be other code paths that
run into _cleanup() where the pkgadd might have not been run, like
check_cancel_event() or from inside _parse_input() where the input
parameters might have been bad.
"pkgadm sync .." will sync the pending operations on contents db file.
In case where pkgadd have not been run, there will be no pending
operations and it will just return. So there are no consequences in
other scenarios.
Thanks,
Nirmal
thanks,
-ethan
On 08/22/12 07:35, Nirmal Agarwal wrote:
Hi all,
Can I please get 2 code reviews for CR 7192373.
7192373 AI installation fails when SVR4 packages are specified in
manifest
Webrev:
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7192373/webrev/
Pep8 is clean.
Pylint output is unchanged.
Unit tests : Pass
Testing :
--> AI installation on physical system with SVR4 packages specified
in manifest
--> Non Global Zone installation on an installed system using
manifest with SVR4 packages specified.
Regards,
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
