Nirmal:
Your py files are not pep8 clean. With the new pep8 1.3.3, the
following issues should be fixed:
/usr/lib/python2.6/vendor-packages/solaris_install/transfer/svr4.py:291:72:
E502 the backslash is redundant between brackets
int((float(self.total_size) / AbstractSVR4.DEFAULT_SIZE) * \
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:91:70:
E502 the backslash is redundant between brackets
CHECKPOINTS_BEFORE_TI = ["target-discovery", "target-selection", \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:92:50:
E502 the backslash is redundant between brackets
"ai-configuration", "var-share-dataset", \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:163:62:
E502 the backslash is redundant between brackets
as_doc_dict = self.doc.volatile.get_first_child( \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:309:74:
E502 the backslash is redundant between brackets
parser.error("Cannot specify to stop installation before " + \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:314:76:
E502 the backslash is redundant between brackets
parser.error("Cannot specify a stop checkpoint and to stop " + \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:388:64:
E502 the backslash is redundant between brackets
skip_console_msg=(self.options.list_checkpoints or \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:398:65:
E502 the backslash is redundant between brackets
hide_progress=(self.options.list_checkpoints or \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:516:70:
E502 the backslash is redundant between brackets
"preserve unavailable zpools." % \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:546:63:
E502 the backslash is redundant between brackets
self.logger.error("Derived/Parse Manifest " + \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:559:55:
E502 the backslash is redundant between brackets
self.logger.debug("DOC XML: %s" % \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:561:76:
E502 the backslash is redundant between brackets
self.logger.info("Automated Installation paused at " + \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:581:51:
E502 the backslash is redundant between brackets
self.logger.debug("DOC XML: %s" % \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:583:72:
E502 the backslash is redundant between brackets
self.logger.info("Automated Installation paused at " + \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:597:77:
E502 the backslash is redundant between brackets
self.logger.error("Invalid stop checkpoint specified: %s" % \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:667:51:
E502 the backslash is redundant between brackets
self.logger.debug("DOC XML: %s" % \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:669:72:
E502 the backslash is redundant between brackets
self.logger.info("Automated Installation paused at " + \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:705:69:
E502 the backslash is redundant between brackets
self.logger.info("Deriving manifest from: %s" % \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:718:69:
E502 the backslash is redundant between brackets
dm = DerivedManifestData(DERIVED_MANIFEST_DATA, \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:726:70:
E502 the backslash is redundant between brackets
self.logger.info("Registering Derived Manifest " \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:747:75:
E502 the backslash is redundant between brackets
self.logger.error("Uncaught exception parsing manifest: %s" % \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:762:78:
E502 the backslash is redundant between brackets
self.logger.debug("Executing Derived Manifest and Manifest " \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:772:68:
E502 the backslash is redundant between brackets
if not self.execute_checkpoints(pause_checkpoint=pause_cp, \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:810:62:
E502 the backslash is redundant between brackets
self.logger.debug("Resuming at checkpoint: %s" % \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:855:68:
E502 the backslash is redundant between brackets
self.logger.debug("Checkpoints Completed: DOC: \n%s\n\n" % \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:1046:69:
E502 the backslash is redundant between brackets
"Unexpected image dir in software " \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:1047:51:
E502 the backslash is redundant between brackets
"node '%s': %s" % \
^
/usr/lib/python2.6/vendor-packages/solaris_install/auto_install/auto_install.py:1190:58:
E502 the backslash is redundant between brackets
tf_doc_dict = self.doc.volatile.get_first_child( \
^
On 08/22/12 07:46 AM, Nirmal Agarwal wrote:
Hi all,
The below also contain fix for CR 7183288.
7183288 Installing SVR4 package with AI stops with an error and
prevents from automatic reboot
Thanks,
Nirmal
On 08/22/12 20:05, Nirmal Agarwal wrote:
Hi all,
Can I please get 2 code reviews for CR 7192373.
7192373 AI installation fails when SVR4 packages are specified in
manifest
Webrev:
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7192373/webrev/
Pep8 is clean.
Pylint output is unchanged.
Unit tests : Pass
Testing :
--> AI installation on physical system with SVR4 packages specified
in manifest
--> Non Global Zone installation on an installed system using
manifest with SVR4 packages specified.
Regards,
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
