Hi Darren,
Thanks for the review. I have updated the webrev to show both the CR's.
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7192373-rev1/webrev/
On 8/22/2012 8:53 PM, Darren Kenny wrote:
Hi Nirmal,
I'm assuming that the change for pkgadm sync is for the bug 7183288, since
I can't see any direct relation to the bug 7192373, right?
The code changes look good to me.
w.r.t. testing, have you also tested that non-SVR4 installs, or even mixed
IPS and SVR4 installs for AI clients and zones install work too?
I just did the following tests successfully:
--> non-svr4 install on AI client
--> non-svr4 install on Non global zone (already installed system)
--> installed client with a zone and IPS packages
Thanks,
Nirmal
Thanks,
Darren.
On 22/08/2012 15:35, Nirmal Agarwal wrote:
Hi all,
Can I please get 2 code reviews for CR 7192373.
7192373 AI installation fails when SVR4 packages are specified in manifest
Webrev:
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7192373/webrev/
Pep8 is clean.
Pylint output is unchanged.
Unit tests : Pass
Testing :
--> AI installation on physical system with SVR4 packages specified in
manifest
--> Non Global Zone installation on an installed system using manifest
with SVR4 packages specified.
Regards,
Nirmal
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
