Hi Jack,

Thanks for the review. I updated the workspace to reflect both the CR's.

https://cr.opensolaris.org/action/browse/caiman/nirmal27/7192373-rev1/webrev/

Regards,
Nirmal

On 8/22/2012 10:46 PM, Jack Schwartz wrote:
Hi Nirmal.

Looks good!

Webrev should reflect that the fix for svr4.py is really 7183288, not 7192373.

    Thanks,
    Jack

On 08/22/12 07:35 AM, Nirmal Agarwal wrote:
Hi all,

Can I please get 2 code reviews for CR 7192373.

7192373 AI installation fails when SVR4 packages are specified in manifest

Webrev:
https://cr.opensolaris.org/action/browse/caiman/nirmal27/7192373/webrev/

Pep8 is clean.
Pylint output is unchanged.

Unit tests : Pass

Testing :
--> AI installation on physical system with SVR4 packages specified in manifest --> Non Global Zone installation on an installed system using manifest with SVR4 packages specified.

Regards,
Nirmal

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to