Craig here. First off, no offense taken, Mark. Discussion is good. The main issue I struggled with when modifying this code was how much to clean and restructure versus having my changes be legible to a reviewer. For the latest submission, I settled on minimal changes. Fewer, legible changes means less time spent by the reviewer and decreases the chances that I broke something and no one catches it. Anyway, that's how I think about it.
I'd also like my changes to used by Heroine Virtual, and again my guess is that fewer changes are easier to review and merge. But is this a priority with Cinelerra-CV? As much as I wish otherwise, I do not anticipate having much time to spare for development, and will probably remain an occasional contributor. I'd love some submission guidelines. Craig. mark carter wrote: > > I think the problem we're seeing is that there's good code going into > mob that is not seeing its way upstream. And I don't think it ever > will. I'm not sure that the svn commiters pay much attention to what's > going into mob. Perhaps we need someone who will clear patches. This > can be difficult work. For example, I decided to take a look at the > latest commit. It was by Craig Lawson. Now, what I am about to say is > in no way meant to be a disrespect to Craig. If I were to review that > commit, then, as a raw developer in cine, I'd be trying to ask myself > what the problem is, and how his solution solved the problem. If I > were doing my job meticulously, I'd look up what roundf() does, and > try to convince myself that it does the right thing compared to int( > ... + 0.5). I'd also note what appears to be some dubious code quality > ... there's a block that seems repeated twice, but with slightly > different values. Again, I want to emphasise that I'm not criticising > Craig! There'd be quite a lot of work to do, even for a simple patch. > From what little I've seen of the Cinelerra code, it's a big victim of > cut-and-paste programming. I'm sure it did what it was supposed to do > for the original author at the time, but to an outsider, it's very > very messy. > > I think it would be very useful to have someone act as a clearing > house for bug fixes. It's /possible/ (no promises!) that I might have > some free time in the new year, and could contribute in this way. > > _______________________________________________ Cinelerra mailing list [email protected] https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra
