> Seb/Cathy, > > I've been working on a wad of additional improvements to the UV sources. > While many of the changes are just comment/message fix-ups and other nits, > there are some substantive changes too: > > * All of the dl_* routines (that were in strplumb.c, nfs_dlinet.c > and softmac_ctl.c) have been unified into a single set of > routines under sundlpi.h, with headers in <sys/dlpi.h>. The new > routines also fix a number of bugs in the old code, such > incorrect assumptions that an M_PROTO/M_PCPROTO message will > always have at least 4 bytes and that the SAP is always at the > end of the DLSAP address. > > * A variety of ioctl-related simplifications and bugfixes have > been made to dld_drv.c. > > * A new softmac_process_dlpi() utility routine in softmac_ctl.c. > > * A number of unnecessary dependencies on Ethernet have been > removed from the softmac code. > > I'm still in the process of testing these changes, but I'd like to kick > off the review now so that I can hopefully putback the wad before the > end of the week. > > BTW, I'll be filing a Nevada bug for the dl_* duplication, which we can > just toss into the UV Nevada putback. > > webrev: http://cr.opensolaris.org/~meem/uv-tweaks > cscope: /net/atlantic.east/export/ws/meem/uv-tweaks/usr/src >
Meem, I am still looking at your changes. One thing came to my mind is whether you can also move the dlpi_prim_str() function (in ip.c) to sundlpi.c as well, to remove the need of the 2nd and 4th argument of the dl_op() function? Thanks - Cathy
