[clearview-discuss] UV improvements

[Cathy Zhou]

Peter Memishian wrote:
>  > >  > >>      webrev: http://cr.opensolaris.org/~meem/uv-tweaks
>  > >  > >>      cscope: /net/atlantic.east/export/ws/meem/uv-tweaks/usr/src
>  > > 
>  > > I've updated the webrev and cscope.  It also includes the dl_primstr()
>  > > changes.  I also found and removed one more homegrown dl_info() routine.
>  > > 
>  > The change is not correct. You should break if dl_notify() returns
>  > ENOSUPP, and continue otherwise.
> 
> I think what you're asking for is:
> 
>               switch (dl_notify(lh, &notes, NULL)) { 
>                 case 0: 
>                         softmac->smac_notifications = notes; 
>                         break; 
>                 case ENOTSUP: 
>                         break; 
>                 default: 
>                         (void) ldi_close(lh, FREAD|FWRITE, kcred); 
>                         continue; 
>                 } 
> 
> That is: in both the 0 and ENOTSUP cases, we consider this instance usable
> -- but for other errors, we consider it broken and move on to the next
> instance.
> 
That is correct.

>  > >  > softmac_ctl.c
>  > >  > 
>  >
>  > Additional comment: as you have new dl_primstr() function now, you can
>  > get rid of the last argument of softmac_process_dlpi() now. Also, lots
>  > of hardcoded string in softmac_rput_process_proto() can be replaced
>  > too.
> 
> Done.  Webrev is updated.
> 
Looks good.

Thank you
- Cathy