Peter Memishian wrote: > > * 955: This comment's formatting is strange to me, and not in line with > > other block comments. I'd rather all lines be left-justified completely, > > and paragraphs be separated by a blank line. (Yes, I realize it was like > > that before.) > > > > * 956: s/update/updated/ > > I've overhauled the comment. Let me know what you think.
Looks good. > > usr/src/uts/common/io/ib/clients/rds/rds_ioctl.c > > > > * 139,141: Question: why is this needed? > > Apparently, they want to prevent most signals from interrupting the > operation (if the thread has user context). The original code did the > same thing, so I wanted to preserve that behavior. (Personally, I'm > suspicious of the code but it's pretty far afield from UV so I didn't want > to mess with it.) Strange, but I'm fine with your code if it's preserving existing behavior. Thanks, -Seb
