Peter Memishian wrote: > > >> webrev: http://cr.opensolaris.org/~meem/uv-tweaks > > >> cscope: /net/atlantic.east/export/ws/meem/uv-tweaks/usr/src > > I've updated the webrev and cscope. It also includes the dl_primstr() > changes. I also found and removed one more homegrown dl_info() routine. > > > softmac_main.c > > > > - Line 611 > > > > What if dl_notify() returns 0? Note that softmac->smac_notifications > should only be set > > when dl_notify() returns 0. > > Agreed. > The change is not correct. You should break if dl_notify() returns ENOSUPP, and continue otherwise.
> > softmac_ctl.c > > Additional comment: as you have new dl_primstr() function now, you can get rid of the last argument of softmac_process_dlpi() now. Also, lots of hardcoded string in softmac_rput_process_proto() can be replaced too. - Cathy
