> > webrev: http://cr.opensolaris.org/~meem/uv-tweaks > > cscope: /net/atlantic.east/export/ws/meem/uv-tweaks/usr/src > > Just a couple of minor comments: > > usr/src/uts/common/io/dld/dld_drv.c > > * 662: should be mod_hash_key_t
Yep -- can't believe I messed up that line twice now. > * 955: This comment's formatting is strange to me, and not in line with > other block comments. I'd rather all lines be left-justified completely, > and paragraphs be separated by a blank line. (Yes, I realize it was like > that before.) > > * 956: s/update/updated/ I've overhauled the comment. Let me know what you think. > usr/src/uts/common/io/dld/dld_proto.c > > * 1310: you could remove the spurious '.' while you're here. Done. > usr/src/uts/common/io/ib/clients/rds/rds_ioctl.c > > * 139,141: Question: why is this needed? Apparently, they want to prevent most signals from interrupting the operation (if the thread has user context). The original code did the same thing, so I wanted to preserve that behavior. (Personally, I'm suspicious of the code but it's pretty far afield from UV so I didn't want to mess with it.) -- meem
