Sebastien Roy wrote:
> Cathy Zhou wrote:
>> The webrev is also updated to reflect the change. I'd like to have at
>> least two reviewers:
>>
>> http://cr.opensolaris.org/~yun/webrev_dlmgmtd/
>
> Looks good. A few nits:
>
> General:
>
> * Remember to add the PSARC case to the delta comments and putback
> comments.
>
> usr/src/cmd/dlmgmtd/dlmgmt_impl.h
>
> * 131,132: Not that this uid and gid will ever change, but I'm thinking
> that it would be cleaner to obtain the uid and gid buy doing a
> getpwnam() lookup on the string "dladm" instead of hardcoding these
> values in the header file.
>
>
> usr/src/cmd/dlmgmtd/dlmgmt_main.c
>
> * 106,162,257,361: All of these events are fatal to the daemon, and thus
> these messages should be more than mere warnings. LOG_ERR would be more
> appropriate.
>
> * 257,361: It looks like we log two redundant log messages for the same
> error here.
>
I've made changes based on your comments and did some sanity testing. The
webrev is updated:
http://cr.opensolaris.org/~yun/webrev_dlmgmtd/
Thanks
- Cathy
