Sebastien Roy wrote: > Cathy Zhou wrote: >> I've made changes based on your comments and did some sanity testing. >> The webrev is updated: >> >> http://cr.opensolaris.org/~yun/webrev_dlmgmtd/ > > usr/src/cmd/dlmgmtd/dlmgmt_main.c > > * 249: This call to getgrnam() isn't necessary, as you can obtain > "dladm"'s group by looking at pw->pw_gid. > Sure. I will change that.
> * 256: I meant to ask before; what is the purpose of the chmod() here? > We created the directory with mode 0755 at 241. > This is for the case that the /etc/svc/volatile/dladm directory already exists with a different permission. The code used to check whether statbuf.st_mode is 0755 and only call chmod() when it is not, but a reviewer of UV said that check is not necessary, and we can simply "blindly" chmod() it to 0755. Thanks - Cathy
