Cathy Zhou wrote:
> I've made changes based on your comments and did some sanity testing.
> The webrev is updated:
> 
>       http://cr.opensolaris.org/~yun/webrev_dlmgmtd/

usr/src/cmd/dlmgmtd/dlmgmt_main.c

* 249: This call to getgrnam() isn't necessary, as you can obtain 
"dladm"'s group by looking at pw->pw_gid.

* 256: I meant to ask before; what is the purpose of the chmod() here? 
We created the directory with mode 0755 at 241.

-Seb

Reply via email to