On Fri, 6 Nov 2026 11:57:57 GMT, Alexander Zvegintsev <[email protected]> 
wrote:

>> This fix resolves problems with styles of logical fonts on OL 10.2 - and any 
>> other Linux where a font variation is used as the first component of the 
>> Linux sans/serif/monospace desktop fonts.
>> 
>> It skips such initial fonts - as identified by [wght] in the name, which 
>> seems sufficient for now, although not fool proof.
>> The alternative is opening the fonts to see if they are variation fonts 
>> during the process of gathering the names.
>> That is something we don't really want to do. That's why we use fontconfig.
>> If we need to refine this later, we will, but hopefully before that is 
>> needed we'll have proper variation support.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> src/java.desktop/unix/native/common/awt/fontpath.c line 1133:
> 
>> 1131:              * For weight, allow some "slack".
>> 1132:              */
>> 1133:             if (fontCount == 0 && skippedVarFont && (j < (nfonts / 
>> 2))) {
> 
> Could the style check run before updating `unionCharset`?
> 
> If a candidate is rejected here, its `charset` has already been included.

Yes, I thought I'd done that .. fixing

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33761#discussion_r4494338262

Reply via email to