On Fri, 6 Nov 2026 18:47:08 GMT, Phil Race <[email protected]> wrote:
>> This fix resolves problems with styles of logical fonts on OL 10.2 - and any
>> other Linux where a font variation is used as the first component of the
>> Linux sans/serif/monospace desktop fonts.
>>
>> It skips such initial fonts - as identified by [wght] in the name, which
>> seems sufficient for now, although not fool proof.
>> The alternative is opening the fonts to see if they are variation fonts
>> during the process of gathering the names.
>> That is something we don't really want to do. That's why we use fontconfig.
>> If we need to refine this later, we will, but hopefully before that is
>> needed we'll have proper variation support.
>>
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8396849
src/java.desktop/unix/native/common/awt/fontpath.c line 1069:
> 1067: fontformat = NULL;
> 1068: if (fontCount == 0) {
> 1069: (*FcPatternGetString)(fontPattern, FC_FILE, 0,
> &filename);
The `(*FcPatternGetString)(fontPattern, FC_FILE, 0, &filename)` also does not
check the return value.
I am not sure whether this particular call can fail, but the `filename` is
uninitialized and is passed directly to `strstr`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33761#discussion_r4497627771
