On Mon, 9 Nov 2026 22:52:28 GMT, Phil Race <[email protected]> wrote:
>> This fix resolves problems with styles of logical fonts on OL 10.2 - and any
>> other Linux where a font variation is used as the first component of the
>> Linux sans/serif/monospace desktop fonts.
>>
>> It skips such initial fonts - as identified by [wght] in the name, which
>> seems sufficient for now, although not fool proof.
>> The alternative is opening the fonts to see if they are variation fonts
>> during the process of gathering the names.
>> That is something we don't really want to do. That's why we use fontconfig.
>> If we need to refine this later, we will, but hopefully before that is
>> needed we'll have proper variation support.
>>
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8396849
src/java.desktop/unix/native/common/awt/fontpath.c line 1093:
> 1091: if (vp != NULL) {
> 1092: FcBool variable = FcFalse;
> 1093: FcResult res = (*FcPatternGetBool)(vp,
> FC_VARIABLE, 0, &variable);
Shouldn't we call `FcPatternDestroy` on the `vp` to avoid leaking it?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33761#discussion_r4525037882