On Fri, 6 Nov 2026 21:11:28 GMT, Alexander Zvegintsev <[email protected]> 
wrote:

>> Phil Race has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8396849
>
> src/java.desktop/unix/native/common/awt/fontpath.c line 1069:
> 
>> 1067:             fontformat = NULL;
>> 1068:             if (fontCount == 0) {
>> 1069:                 (*FcPatternGetString)(fontPattern, FC_FILE, 0, 
>> &filename);
> 
> The `(*FcPatternGetString)(fontPattern, FC_FILE, 0, &filename)` also does not 
> check the return value.
> I am not sure whether this particular call can fail, but the `filename` is 
> uninitialized and is passed directly to `strstr`.

The latest commit to re-do how we decide it is a variation checks the return 
value

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33761#discussion_r4518897403

Reply via email to