On Fri, 6 Nov 2026 18:47:29 GMT, Phil Race <[email protected]> wrote:

> I don't actually see how the calls could fail - these are standard properties 
> and fontconfig should always return a value.

`FcPatternGetInteger` can return `FcResultTypeMismatch` even for a standard 
property such as `FC_WEIGHT`.
e.g. [this report](https://bugzilla.redhat.com/show_bug.cgi?id=1813187#c4) 
describes a variable font’s meta face whose weight is represented as a 
`FcTypeRange`, and not the `FcTypeInteger`.

The recently added filename check does not exclude every variable font, so it 
does not rule out this case.

So it is safer to check for the return value.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33761#discussion_r4497585694

Reply via email to