2009/6/28 Lucio Torre <[email protected]>: > > On Sun, Jun 28, 2009 at 12:53 AM, Arnaud Bergeron<[email protected]> wrote: >> Any updates on this? >> >> I have not seen any commits nor received any comments (positive or negative). >> > > Im reviewing the patches: > - the color patch for color layer is in.
Ok. > - im not merging the float scroll for tiles, because thats richards > code and richard always insists on having position set to an int. So > you will have to discuss that with him. Ok. Richard: Can you tell my why you insist on having the position as an int? > - the unscaled resize windows patch conflicts with changes made on the > cocos2d-editor branch (the future trunk). Could you review those > please? The conflict is because the trunk and the cocos2d-editor branch differ on that file. The trunk has an incomplete fix and the branch has none. So you can use the attached patch on the branch and it should make them both do the same thing. > - the scroll fullscreen is in. ive tried running test_tiles in > fullscreen with and without it, and although it does strange things in > both cases, i like the version with the patch more. It needs the proper rescale thing that is in the previous patch to not go haywire when the screen changes > - as facundo commented, theres get_virtual_coordinates that does the > work of get_virtual_displacement. Is there something going on with > that function that i am missing? get_virtual_coordinates() is for when you get a mouse postion as (x,y) in window coordinates. get_virtual_displacement() is the analogue for (dx, dy) like you get in the on_mouse_motion() callback. It scales the displacement vector according the the ration between the current real size of the window and the configured size. > This is for r864. > > Again, thanks for your patches and sorry for the delay. No problem. Arnaud > Lucio. > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "cocos2d discuss" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/cocos-discuss?hl=en -~----------~----~----~----~------~----~------~--~---
resize-window_editor.patch
Description: Binary data
