tirkarthi commented on code in PR #23654:
URL: https://github.com/apache/airflow/pull/23654#discussion_r870993079
##########
airflow/providers/amazon/aws/hooks/s3.py:
##########
@@ -846,15 +846,14 @@ def delete_objects(self, bucket: str, keys: Union[str,
list]) -> None:
@provide_bucket_name
@unify_bucket_name_and_key
def download_file(
- self, key: str, bucket_name: Optional[str] = None, local_path:
Optional[str] = None
+ self, key: str, bucket_name: Optional[str] = None, filename:
Optional[str] = None
Review Comment:
Filename is made optional here with `None` as default value. It seems
filename cannot be `None` as per Boto S3 docs. What happens when `filename` is
not passed?
This is also a change in the documented interface and might need changelog
update :
https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/_api/airflow/providers/amazon/aws/hooks/s3/index.html?highlight=download_file#airflow.providers.amazon.aws.hooks.s3.S3Hook.download_file
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3.html#S3.Client.download_file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
